[llvm-commits] PATCH: add backreference support to Regex

[Sean Silva]

I guess the question for me about this patch is "what is it that you
want reviewed?". I think most people understand why this is necessary,
but I don't think that anyone is really that familiar with this code
at all (it looks like it was simply imported directly from OpenBSD)
and so you should really explain what it is that needs to be reviewed
here, because otherwise it's hard to give an opinion about it.

Also, one question that comes to mind is how have you tested this? I'm
guessing that the unittests pass and that you rebuilt and ran the
entire test suite to see if anything breaks, but it would be nice if
you explicitly mentioned it.

-- Sean Silva

On Wed, Nov 28, 2012 at 8:09 AM, Eli Bendersky <eliben at google.com> wrote:
> On Mon, Nov 26, 2012 at 6:55 AM, Eli Bendersky <eliben at google.com> wrote:
>> Hello,
>>
>> This is the the second patch (*) on the way to implement the FileCheck
>> enhancement described here:
>> http://lists.cs.uiuc.edu/pipermail/llvmdev/2012-November/055840.html
>>
>> It adds backreference matching capabilities to Support/Regex, with
>> appropriate unit tests. This change in itself is not expected to
>> affect any functionality at this point, but it will serve as a
>> stepping stone to improve FileCheck's variable matching capabilities.
>>
>> Notes:
>>
>> 1. I had to insert tabs in regcomp.c to preserve existing formatting
>> 2. Support for BREs was added to Regex - but it's easy to remove if
>> it's not required
>> 3. I documented the addition in the comment at the top of Regex.h, I
>> don't think we have a non-code document for regex capabilities, please
>> correct me if I'm wrong.
>>
>> Eli
>>
>> (*) The first is r168588 - rewrite the single existing test actually
>> using the current capability.
>
> Ping
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits