[llvm-commits] [PATCH] Enable atomic64 min/max operations on ARM

[Silviu Baranga]

Hi Renato,

Thanks for the review. I'll wait a while before committing to see
if there are any objections.

Cheers,
Silviu

> -----Original Message-----
> From: rengolin at gmail.com [mailto:rengolin at gmail.com] On Behalf Of
> Renato Golin
> Sent: 28 November 2012 09:07
> To: Silviu Baranga
> Cc: llvm-commits at cs.uiuc.edu for LLVM
> Subject: Re: [llvm-commits] [PATCH] Enable atomic64 min/max operations
> on ARM
> 
> Hi Silviu,
> 
> I can't see anything wrong with it, but then again, it's been a while
> that I've looked to ISelLowering.
> 
> Unless anyone else has any objections, LGTM.
> 
> cheers,
> --renato
> 
> On 26 November 2012 16:38, Silviu Baranga <silbar01 at arm.com> wrote:
> > Hi,
> >
> > The attached patch implements code generation for atomic64
> min/max/umin/umax
> > Operations for ARM. The patch extends the functionality of the
> > EmitAtomicBinary64
> > Function to achieve this.
> >
> > The compare operation needed to implement this is done using sub/sbc
> > instructions, in order to unify the signed and unsigned cases.
> >
> > The patch also adds tests for all the implemented operations.
> >
> > Please review!
> >
> > Thanks,
> > Silviu
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> >
> 
> 
> 
> --
> cheers,
> --renato
> 
> http://systemcall.org/