[llvm-commits] [PATCH] Teach llvm-objdump to dump Win64 exception tables

[Sean Silva]

Looks pretty much good. Besides a few minor things I've mentioned
below, it looks good as far as I can tell. Michael, can you look this
over and give it a final review?

+  /* The data after unwindCodes depends on flags.
+   * If UNW_ExceptionHandler or UNW_TerminateHandler is set then follows
+   * the address of the language-specific exception handler.
+   * If UNW_ChainInfo is set then follows a RuntimeFunction which defines
+   * the chained unwind info.
+   * For more information please see MSDN at:
+   * http://msdn.microsoft.com/en-us/library/ddssxxy8.aspx
+   */

Use C++ comments for this (this is actually in the coding standards).

+  /// getLanguageSpecificData - Return pointer to language specific data part
+  /// of UnwindInfo.

Use \brief. Instead of duplicating the name.

http://llvm.org/docs/CodingStandards.html#doxygen-use-in-documentation-comments

+      printCOFFSymbolAddress(outs(), Rels, SectionOffset +
+                              offsetof(RuntimeFunction, StartAddress),

Please align these. the 'o' of "offsetof" should be under the 'o' of "outs()".

-- Sean Silva