[llvm-commits] [PATCH/RFC] Only use .lcomm if it supports alignment

[Ulrich Weigand]

Benjamin Kramer <benny.kra at gmail.com> wrote on 27.11.2012 16:06:11:
> On 27.11.2012, at 15:05, Ulrich Weigand <Ulrich.Weigand at de.ibm.com>
wrote:
> > Thus, it would appear to me that the simplest fix would be to simply
never
> > use .lcomm and always fall back to .local / .comm on targets
where .lcomm
> > does not support an alignment argument.  The attached patch implements
> > this.  (Note that two tests need to be modified to check for the new
> > behaviour instead of the old one.)
> >
> > Tested on powerpc64-linux with no regression; with this patch, the
> > integrated and the external assembler produce 100% identical data
sections
> > (.data, .bss, .rodata ...) on all objects in test-suite.  (There are
still
> > differences in .eh_frame and debug sections.)
> >
> > OK to commit?
>
> LGTM!

Checked in as revision 168704.

Thanks,
Ulrich