[llvm-commits] [llvm] r168558 - in /llvm/trunk: lib/Transforms/Vectorize/LoopVectorize.cpp test/Transforms/LoopVectorize/no_int_induction.ll

Sebastian Pop spop at codeaurora.org
Mon Nov 26 10:06:26 PST 2012


Nadav Rotem wrote:
> -                            DominatorTree *dt, LPPassManager *Lpm,
> +                            DominatorTree *dt, DataLayout *dl,

Please use capital letters for the first letter of a variable name.
s/dt/Dt/
s/dl/Dl/

> +  // Data Layout;

s/;/./

> +    void insert_pointer(ScalarEvolution *SE, Loop *Lp, Value *Ptr) {

s/insert_pointer/insertPointer/g

> +          WidenMap[Inst] = PHINode::Create(VecTy, 2, "vec.phi",
> +                                  LoopVectorBody->getFirstInsertionPt());

Indentation is incorrect.

> +        // Handle pointer inductions:

s/:/./

Thanks,
Sebastian
-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation



More information about the llvm-commits mailing list