[llvm-commits] [llvm] r168181 - in /llvm/trunk: lib/Transforms/InstCombine/InstCombineCompares.cpp test/Transforms/InstCombine/icmp.ll

[Duncan Sands]

>>> I propose as below, two options;
>>>
>>> 1) r168186 and r168196
>>
>> I think this is the best option, as the first of these does fix a real bug
>> (though it's hard to get a miscompile out of it, it is theoretically possible).
>> The corresponding instcombine patch was already approved by Chris and applied;
>> this is exactly the same fix but for duplicated code in instsimplify.  The
>> second patch improves the comments and (more importantly) gets rid of a warning
>> when building with clang.  It is zero risk, so should just be applied.
>>
>> In short, I approve applying both of these.
>>
>> That said, I'm not the code owner: Chris is (by default since no code owner
>> has been assigned yet).  Chris?
>
> I approve.

Thanks Chris.

Best wishes, Duncan.