[llvm-commits] Improved Covered Default Switch detection

Óscar Fuentes ofv at wanadoo.es
Sun Nov 25 17:02:50 PST 2012


Óscar Fuentes <ofv at wanadoo.es> writes:

>> Interesting. Can you apply my patch and test to see if it works with
>> your builds?
>
> It's too late here, sorry, but your patch seems plain correct.
>
> The unrelated set(... -> list(APPEND changes shouldn't be mixed with the
> fix proper, IMO. Same for the cmake_minimum_required command. LLVM
> already requires cmake version 2.8 on the top CMakeLists.txt.

BTW, you want

set(FOO "${FOO} something")

instead of

list(APPEND FOO something)

because those variables are strings, not lists. Using the `list' version
may cause unwanted semicolons in the command line.




More information about the llvm-commits mailing list