[llvm-commits] [LLVMdev] [PATCH] fast-math patches!

[Evan Cheng]

On Nov 16, 2012, at 7:15 PM, Krzysztof Parzyszek <kparzysz at codeaurora.org> wrote:

> On 11/15/2012 12:38 PM, Evan Cheng wrote:
>> 
>> The patch looks good in general. But I'm a bit concerned about the textural representation about these flags. 'N', 'I', 'S', 'R', 'A' seem cryptic to me. Does it make sense to expand them a bit 'nnan', 'inf', etc.? They definitely need to be documented.
> 
> They aren't any more cryptic than, for example, nuw.  Once you remember what they mean there won't be any trouble reading them.  Since you can combine them, the instructions that have multiple of those could become obnoxiously long.

That's definitely true. However, I don't believe it's common for instructions to have multiple flags. It seems like the most common case for C would be "fast" and perhaps we can add other flags for other combinations of flags that would come up frequently.

Evan

> 
> -Krzysztof
> 
> 
> -- 
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits