[llvm-commits] [llvm] r168316 - in /llvm/trunk/test/ExecutionEngine: MCJIT/lit.local.cfg lit.local.cfg

Wed Nov 21 17:13:02 PST 2012

Andy,

> Pawel,
> 
> As MCJIT code owner, I approve the merging of r168364 into the 3.2 branch.
> 
> I'll put it there shortly.

OK, it is there, merged in r168392.
Pawel

> 
> -Andy
> 
> -----Original Message-----
> From: NAKAMURA Takumi [mailto:geek4civic at gmail.com] 
> Sent: Tuesday, November 20, 2012 2:35 PM
> To: Kaylor, Andrew
> Cc: Hal Finkel; llvm-commits
> Subject: Re: [llvm-commits] [llvm] r168316 - in /llvm/trunk/test/ExecutionEngine: MCJIT/lit.local.cfg lit.local.cfg
> 
> 2012/11/21 Kaylor, Andrew <andrew.kaylor at intel.com>:
>> Will the 3.2 testing go better if this is merged there?
> 
> Definitely!
> 
> That said, I have no idea it would make sense if clang-ppc-linux were being kept green. :D http://bb.pgr.jp/builders/clang-ppc-linux
> 
> ...Takumi
> 
>> -----Original Message-----
>> From: llvm-commits-bounces at cs.uiuc.edu 
>> [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of NAKAMURA Takumi
>> Sent: Tuesday, November 20, 2012 2:52 AM
>> To: Hal Finkel
>> Cc: llvm-commits
>> Subject: Re: [llvm-commits] [llvm] r168316 - in 
>> /llvm/trunk/test/ExecutionEngine: MCJIT/lit.local.cfg lit.local.cfg
>>
>> Suppressed on ppc32 in r168364. Lemme know if it were harmful on ppc64.
>>
>> 2012/11/20 Hal Finkel <hfinkel at anl.gov>:
>>> ----- Original Message -----
>>>> From: "NAKAMURA Takumi" <geek4civic at gmail.com>
>>>> To: "Hal Finkel" <hfinkel at anl.gov>, fang at csl.cornell.edu
>>>> Cc: "llvm-commits" <llvm-commits at cs.uiuc.edu>, "Ulrich Weigand"
>>>> <ulrich.weigand at de.ibm.com>
>>>> Sent: Tuesday, November 20, 2012 12:28:33 AM
>>>> Subject: Re: [llvm-commits] [llvm] r168316 - in
>>>> /llvm/trunk/test/ExecutionEngine: MCJIT/lit.local.cfg lit.local.cfg
>>>>
>>>> Hal,
>>>>
>>>> I understand ppc64 should be promoted as possible, though.
>>>>
>>>> We could take options;
>>>>
>>>> 1) Suppress problematic mcjit tests on ppc32 (not on ppcp64).
>>>>     FYI, I tweaked so in r167231 in past.
>>>> 2) Implement minimal tweaks into MC and rtdyld for ppc32.
>>>>     I know a few functions are not implemented in ppc32-elf.
>>>>
>>>> Anyway, I will tweak either to trunk tonight.
>>>
>>> Great, thanks!
>>>
>>>  -Hal
>>>
>>>>
>>>> ...Takumi
>>>>
>>>> 2012/11/20 Hal Finkel <hfinkel at anl.gov>:
>>>>> ----- Original Message -----
>>>>>> From: "NAKAMURA Takumi" <geek4civic at gmail.com>
>>>>>> To: "Ulrich Weigand" <ulrich.weigand at de.ibm.com>
>>>>>> Cc: "llvm-commits" <llvm-commits at cs.uiuc.edu>, "Hal Finkel"
>>>>>> <hfinkel at anl.gov>
>>>>>> Sent: Monday, November 19, 2012 10:45:55 PM
>>>>>> Subject: Re: [llvm-commits] [llvm] r168316 - in
>>>>>> /llvm/trunk/test/ExecutionEngine: MCJIT/lit.local.cfg 
>>>>>> lit.local.cfg
>>>>>>
>>>>>> It broke ppc32-linux (f12 ps3).
>>>>>>
>>>>>> http://bb.pgr.jp/builders/clang-ppc-linux/builds/693
>>>>>
>>>>> Thanks! We suspected this might happen. We thought, however, that 
>>>>> it was better to show the new MCJIT infrastructure working on
>>>>> PPC64 than to show the deprecated JIT infrastructure functional on 
>>>>> PPC32. Having testing coverage on MCJIT is more important now.
>>>>>
>>>>> Do you know if there is a way to make this change specific to 
>>>>> PPC64?
>>>>>
>>>>>  -Hal
>>>>>
>>>>>>
>>>>>> 2012/11/20 Ulrich Weigand <ulrich.weigand at de.ibm.com>:
>>>>>>> Author: uweigand
>>>>>>> Date: Mon Nov 19 11:57:07 2012
>>>>>>> New Revision: 168316
>>>>>>>
>>>>>>> URL: http://llvm.org/viewvc/llvm-project?rev=168316&view=rev
>>>>>>> Log:
>>>>>>> Enable MCJIT tests on PowerPC.
>>>>>>> Disable old JIT tests on PowerPC.
>>>>>>>
>>>>>>> Modified:
>>>>>>>     llvm/trunk/test/ExecutionEngine/MCJIT/lit.local.cfg
>>>>>>>     llvm/trunk/test/ExecutionEngine/lit.local.cfg
>>>>>>>
>>>>>>> Modified: llvm/trunk/test/ExecutionEngine/MCJIT/lit.local.cfg
>>>>>>> URL:
>>>>>>> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ExecutionEn
>>>>>>> g 
>>>>>>> ine/MCJIT/lit.local.cfg?rev=168316&r1=168315&r2=168316&view=dif
>>>>>>> f 
>>>>>>> ===============================================================
>>>>>>> =
>>>>>>> ==============
>>>>>>> --- llvm/trunk/test/ExecutionEngine/MCJIT/lit.local.cfg
>>>>>>> (original)
>>>>>>> +++ llvm/trunk/test/ExecutionEngine/MCJIT/lit.local.cfg Mon Nov
>>>>>>> 19
>>>>>>> 11:57:07 2012
>>>>>>> @@ -8,12 +8,13 @@
>>>>>>>  root = getRoot(config)
>>>>>>>
>>>>>>>  targets = set(root.targets_to_build.split())
>>>>>>> -if ('X86' in targets) | ('ARM' in targets) | ('Mips' in
>>>>>>> targets):
>>>>>>> +if ('X86' in targets) | ('ARM' in targets) | ('Mips' in
>>>>>>> targets) |
>>>>>>> \
>>>>>>> +   ('PowerPC' in targets):
>>>>>>>      config.unsupported = False
>>>>>>>  else:
>>>>>>>      config.unsupported = True
>>>>>>>
>>>>>>> -if root.host_arch not in ['x86', 'x86_64', 'ARM', 'Mips']:
>>>>>>> +if root.host_arch not in ['x86', 'x86_64', 'ARM', 'Mips',
>>>>>>> 'PowerPC']:
>>>>>>>      config.unsupported = True
>>>>>>>
>>>>>>>  if root.host_os in ['Darwin']:
>>>>>>>
>>>>>>> Modified: llvm/trunk/test/ExecutionEngine/lit.local.cfg
>>>>>>> URL:
>>>>>>> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/ExecutionEn
>>>>>>> g ine/lit.local.cfg?rev=168316&r1=168315&r2=168316&view=diff
>>>>>>> ===============================================================
>>>>>>> =
>>>>>>> ==============
>>>>>>> --- llvm/trunk/test/ExecutionEngine/lit.local.cfg (original)
>>>>>>> +++ llvm/trunk/test/ExecutionEngine/lit.local.cfg Mon Nov 19
>>>>>>> 11:57:07 2012
>>>>>>> @@ -1 +1,12 @@
>>>>>>>  config.suffixes = ['.ll', '.c', '.cpp']
>>>>>>> +
>>>>>>> +def getRoot(config):
>>>>>>> +    if not config.parent:
>>>>>>> +        return config
>>>>>>> +    return getRoot(config.parent)
>>>>>>> +
>>>>>>> +root = getRoot(config)
>>>>>>> +
>>>>>>> +if root.host_arch in ['PowerPC']:
>>>>>>> +    config.unsupported = True
>>>>>>> +
>>>>>>>
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> llvm-commits mailing list
>>>>>>> llvm-commits at cs.uiuc.edu
>>>>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>>>>
>>>>>
>>>>> --
>>>>> Hal Finkel
>>>>> Postdoctoral Appointee
>>>>> Leadership Computing Facility
>>>>> Argonne National Laboratory
>>>>
>>>
>>> --
>>> Hal Finkel
>>> Postdoctoral Appointee
>>> Leadership Computing Facility
>>> Argonne National Laboratory
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 
> 