[llvm-commits] [PATCH] Convert SourceLevelDebugging.html to reST

Eli Bendersky eliben at google.com
Wed Nov 21 12:56:12 PST 2012


> Hmm, it is weird.  I reproduced this on a clean checkout, but I can
> not see what is wrong with patch creation -- I created the patch with
> 'svn diff .'
>
> But 'svn patch /path/to/patch' works.  Seems like svn messed up file
> deletion in the patch... Please remove docs/SourceLevelDebugging.html
> manually.  This should be correct in real commit.
>

Some comments:

* In the "subprogram descriptors" section, the code is not
highlighted. Also in other places. Not sure how important highlighting
is here, but it would be nice to make it consistent
* In the original HTML, LLVMDebugVersion in the metadata listings was
linking to a paragraph explaining it. This is probably not very
important, but nice to have. Is there a simple way to reproduce this
effect in the ReST doc?
* When the HTML version mensions the intrinsics (i.e.
llvm.dbg.declare), they are links. Not in ReST

That's all I encountered from a very cursory glance. Good job,
overall, that's a large document :-)

Eli



More information about the llvm-commits mailing list