[llvm-commits] [PATCH] YAMLParser diagnostics filename

Sean Silva silvas at purdue.edu
Mon Nov 19 15:24:58 PST 2012


Committed as r168341.

Kim, I used (parts of) your first email starting the thread as the
commit message; if you could doublecheck that it looks OK that would
be great.

-- Sean Silva

On Mon, Nov 19, 2012 at 5:33 PM,  <bigcheesegs at gmail.com> wrote:
> On Nov 19, 2012, at 5:11 PM, Sean Silva <silvas at purdue.edu> wrote:
>
>> Michael, would you like me to commit this for Kim?
>>
>> -- Sean Silva
>>
>
> Yes. Thanks.
>
> - Michael Spencer
>
>> On Mon, Nov 19, 2012 at 5:07 PM,  <bigcheesegs at gmail.com> wrote:
>>> On Nov 19, 2012, at 3:52 PM, Kim Gräsman <kim.grasman at gmail.com> wrote:
>>>
>>>> On Mon, Nov 19, 2012 at 9:42 PM, Michael Spencer <bigcheesegs at gmail.com> wrote:
>>>>>
>>>>> Just one more change and it's good. Don't copy documentation to both
>>>>> the header and definition. In this case it should only be in the
>>>>> header.
>>>>
>>>> The comments apply to two different classes (Stream in the header and
>>>> Scanner in the .cpp), and I saw Scanner had some comments already, so
>>>> I figured I might as well expand on them.
>>>
>>> Ah, sorry, didn't. Notice that. The comment is fine then.
>>>
>>>>
>>>>> With that change it's fine to commit. I can't really commit it now as
>>>>> I'm traveling and don't have everything setup.
>>>>
>>>> OK, patch without doc comments on Scanner attached.
>>>>
>>>> Thanks,
>>>> - Kim
>>>> <YAMLParser-diag-filename.patch>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list