[llvm-commits] [PATCH v2] Disable old-JIT and enable MCJIT tests on PowerPC

Ulrich Weigand Ulrich.Weigand at de.ibm.com
Mon Nov 19 08:58:31 PST 2012


Ulrich Weigand/Germany/IBM wrote on 19.11.2012 17:23:58:
> "Kaylor, Andrew" <andrew.kaylor at intel.com> wrote:
>
> > The buildbots are currently skipping the MCJIT ExecutionEngine tests
> > on PowerPC64 and the legacy JIT ExecutionEngine tests are all failing.
> >
> > You can enable the MCJIT tests by modifying llvm/test/
> > ExecutionEngine/MCJIT/lit.local.cfg.  I think it's OK to add PowerPC
> > to the XFAIL list for the legacy JIT tests.
> >
> > I added a few new tests to the MCJIT suite today to verify lli's
> > remote-mcjit option, and it's possible that those will require some
> > minor updates to the relocation handling.
>
> The attached patch implements the above suggestion (enable MCJIT tests
> on PowerPC; XFAIL old-JIT tests on PowerPC).  Is this what you had in
> mind?
>
> All MCJIT tests (as of rev. 168312) pass on PowerPC now.  (In fact,
> with this patch, the test suite as a whole passes.)

Roman Divacky pointed out on IRC that it might be preferable to
disable all old-JIT tests at the directory level instead of
individually XFAILing them.  This alternative patch implements
this suggestion.  All MCJIT tests still pass.

Either version OK to commit?

Bye,
Ulrich

(See attached file: diff-llvm-jit-test-v2)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: diff-llvm-jit-test-v2
Type: application/octet-stream
Size: 1244 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121119/9990fb7f/attachment.obj>


More information about the llvm-commits mailing list