[llvm-commits] [PATCH] YAMLParser diagnostics filename

[bigcheesegs at gmail.com]

On Nov 18, 2012, at 3:10 AM, Kim Gräsman <kim.grasman at gmail.com> wrote:

> Hi all,
> 
> Here's a patch to allow using MemoryBuffers with yaml::Stream directly.
> 
> The rationale is to get YAML filenames in diagnostics from
> yaml::Stream::printError -- currently the filename is hard-coded as
> "YAML" because there's no buffer information available.
> 
> Patch generated from r167960 of trunk.
> 
> I'd love for someone to take a look at this and commit if acceptable.
> 
> Thank you,
> - Kim
> <YAMLParser-diag-filename.patch>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

You need to document the ownership semantics of the MemoryBuffer pointer (SourceMgr takes ownership). See llvm.org/docs/CodingStandards.html#doxygen-use-in-documentation-comments for how to document. Other than that it looks good.

- Michael Spencer