[llvm-commits] [llvm] r168248 - in /llvm/trunk: lib/CodeGen/TargetInstrInfoImpl.cpp test/CodeGen/PowerPC/2012-11-16-mischedcall.ll

Andrew Trick atrick at apple.com
Fri Nov 16 19:35:11 PST 2012


Author: atrick
Date: Fri Nov 16 21:35:11 2012
New Revision: 168248

URL: http://llvm.org/viewvc/llvm-project?rev=168248&view=rev
Log:
Broaden isSchedulingBoundary to check aliases of SP.

On PPC the stack pointer is X1, but ADJCALLSTACK writes R1.

Fixes PR14315: Register regmask dependency problem with misched.

Added:
    llvm/trunk/test/CodeGen/PowerPC/2012-11-16-mischedcall.ll
Modified:
    llvm/trunk/lib/CodeGen/TargetInstrInfoImpl.cpp

Modified: llvm/trunk/lib/CodeGen/TargetInstrInfoImpl.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/TargetInstrInfoImpl.cpp?rev=168248&r1=168247&r2=168248&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/TargetInstrInfoImpl.cpp (original)
+++ llvm/trunk/lib/CodeGen/TargetInstrInfoImpl.cpp Fri Nov 16 21:35:11 2012
@@ -472,7 +472,8 @@
   // stack slot reference to depend on the instruction that does the
   // modification.
   const TargetLowering &TLI = *MF.getTarget().getTargetLowering();
-  if (MI->definesRegister(TLI.getStackPointerRegisterToSaveRestore()))
+  const TargetRegisterInfo *TRI = MF.getTarget().getRegisterInfo();
+  if (MI->modifiesRegister(TLI.getStackPointerRegisterToSaveRestore(), TRI))
     return true;
 
   return false;

Added: llvm/trunk/test/CodeGen/PowerPC/2012-11-16-mischedcall.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/PowerPC/2012-11-16-mischedcall.ll?rev=168248&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/PowerPC/2012-11-16-mischedcall.ll (added)
+++ llvm/trunk/test/CodeGen/PowerPC/2012-11-16-mischedcall.ll Fri Nov 16 21:35:11 2012
@@ -0,0 +1,33 @@
+; RUN: llc -march=ppc64 -enable-misched < %s | FileCheck %s
+;
+; PR14315: misched should not move the physreg copy of %t below the calls.
+
+ at .str89 = external unnamed_addr constant [6 x i8], align 1
+
+declare void @init() nounwind
+
+declare void @clock() nounwind
+
+; CHECK: %entry
+; CHECK: fmr f31, f1
+; CHECK: bl _init
+define void @s332(double %t) nounwind {
+entry:
+  tail call void @init()
+  tail call void @clock() nounwind
+  br label %for.cond2
+
+for.cond2:                                        ; preds = %for.body4, %entry
+  %i.0 = phi i32 [ %inc, %for.body4 ], [ 0, %entry ]
+  %cmp3 = icmp slt i32 undef, 16000
+  br i1 %cmp3, label %for.body4, label %L20
+
+for.body4:                                        ; preds = %for.cond2
+  %cmp5 = fcmp ogt double undef, %t
+  %inc = add nsw i32 %i.0, 1
+  br i1 %cmp5, label %L20, label %for.cond2
+
+L20:                                              ; preds = %for.body4, %for.cond2
+  %index.0 = phi i32 [ -2, %for.cond2 ], [ %i.0, %for.body4 ]
+  unreachable
+}





More information about the llvm-commits mailing list