[llvm-commits] Trivial warning

[Joe Abbey]

On Nov 16, 2012, at 12:38 AM, Joe Abbey <jabbey at arxan.com<mailto:jabbey at arxan.com>> wrote:

Hal (et al),

One of my build bots reported a warning:

PPCRegisterInfo.cpp:501:51: warning: cast from type ‘const llvm::MachineFunction*’ to type ‘llvm::MachineFunction*’ casts away qualifiers [-Wcast-qual]

Index: lib/Target/PowerPC/PPCRegisterInfo.cpp
===================================================================
--- lib/Target/PowerPC/PPCRegisterInfo.cpp (revision 168110)
+++ lib/Target/PowerPC/PPCRegisterInfo.cpp (working copy)
@@ -498,7 +498,8 @@
     } else if (CRSpillFrameIdx) {
       FrameIdx = CRSpillFrameIdx;
     } else {
-      MachineFrameInfo *MFI = ((MachineFunction &)MF).getFrameInfo();
+      MachineFrameInfo *MFI =
+        (const_cast<MachineFunction &>MF).getFrameInfo();
       FrameIdx = MFI->CreateFixedObject((uint64_t)4, (int64_t)-4, true);
       CRSpillFrameIdx = FrameIdx;
     }

Ok to commit?

Past Joe,

Make sure your current build is setup to do PowerPC builds.

Also, swapping a warning for an error is a horrible trade… let's try that patch again:

Index: lib/Target/PowerPC/PPCRegisterInfo.cpp
===================================================================
--- lib/Target/PowerPC/PPCRegisterInfo.cpp (revision 168110)
+++ lib/Target/PowerPC/PPCRegisterInfo.cpp (working copy)
@@ -498,7 +498,8 @@
     } else if (CRSpillFrameIdx) {
       FrameIdx = CRSpillFrameIdx;
     } else {
-      MachineFrameInfo *MFI = ((MachineFunction &)MF).getFrameInfo();
+      MachineFrameInfo *MFI =
+        (const_cast<MachineFunction &>(MF)).getFrameInfo();
       FrameIdx = MFI->CreateFixedObject((uint64_t)4, (int64_t)-4, true);
       CRSpillFrameIdx = FrameIdx;
     }

Joe
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121116/da8d6267/attachment.html>