[llvm-commits] Is AlignOfTest.cpp intentionally testing ambiguous inheritance?

[Joe Abbey]

Basically it goes like this:

struct S1;

struct D1 : S1;

struct D9 : S1, D1;

Are there unique considerations for that which require unit testing? or can we simply pull the multiple inheritance to remove this warning:

AlignOfTest.cpp:59:8: warning: direct base ‘{anonymous}::S1’ inaccessible in ‘{anonymous}::D9’ due to ambiguity [enabled by default]

Index: unittests/Support/AlignOfTest.cpp
===================================================================
--- unittests/Support/AlignOfTest.cpp (revision 168110)
+++ unittests/Support/AlignOfTest.cpp (working copy)
@@ -56,7 +56,7 @@
 struct D6 : S2, S3 {};
 struct D7 : S1, S3 {};
 struct D8 : S1, D4, D5 { double x[2]; };
-struct D9 : S1, D1 { S1 s1; };
+struct D9 : D1 { S1 s1; };
 struct V1 { virtual ~V1(); };
 struct V2 { int x; virtual ~V2(); };
 struct V3 : V1 { virtual ~V3(); };

Just want to make sure we're not losing any coverage by removing this ambiguous multiple inheritance.

Joe

______________________________
Joe Abbey
Director of Software Development
Arxan Technologies
jabbey at arxan.com<mailto:jabbey at arxan.com> www.arxan.com<http://www.arxan.com/>
Protecting the App Economy™



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121116/53a7aced/attachment.html>