[llvm-commits] [PATCH] Fix nondeterministic codegen in stack-coloring pass

Ulrich Weigand Ulrich.Weigand at de.ibm.com
Thu Nov 15 11:34:35 PST 2012


Nadav Rotem <nrotem at apple.com> wrote on 15.11.2012 20:28:38:

> LGTM!
>
>    // Sort the slots according to their size. Place unused slots at the
end.
> -  std::sort(SortedSlots.begin(), SortedSlots.end(), SlotSizeSorter
(MFI));
> +  // Use stable sort to guarantee determinisic code generation.
> +  std::stable_sort(SortedSlots.begin(), SortedSlots.end(),
> +                   SlotSizeSorter(MFI));
>
> You have a typo in "determinisic".

Oops, fixed.  Checked in as revision 168074.

Thanks,
Ulrich




More information about the llvm-commits mailing list