[llvm-commits] [Patch] Make GlobalOpt conservative with TLS vars (PR14309, 3.2-blocker)

[Hans Wennborg]

On Thu, Nov 15, 2012 at 3:28 PM, 32bitmicro <root at 32bitmicro.com> wrote:
>> +Pawel: Is there a procedure for getting this onto the 3.2 branch, or
>> should I just land it there myself?
>
> Yes there is a procedure.
>
> First you need to get this patch approved by the code owner.
> After your patch is approved it can be merged into the 3.2 branch.
> You will need to coordinate with the code owner as to who will
> do the merge.
>
> Please keep me in the loop, it makes it a lot easier to track
> these things.


Chris: I guess you'd be the code owner in this case?


>> On Thu, Nov 15, 2012 at 11:07 AM, Nick Lewycky <nicholas at mxc.ca> wrote:
>>> +    const Constant *C = WorkList.back();
>>> +    WorkList.pop_back();
>>>
>>> const Constant *C = WorkList.pop_back_val();
>>
>> Done.
>>
>>> +      if (!Visited.count(D)) {
>>> +        WorkList.push_back(D);
>>> +        Visited.insert(C);
>>> +      }
>>> '
>>> if (Visited.insert(D)) {
>>>   WorkList.push_back(D);
>>> }
>>
>> Done.
>>
>>> LGTM!
>>
>> Thanks! Landed r168037.
>>
>>  - Hans