[llvm-commits] [Patch] Make GlobalOpt conservative with TLS vars (PR14309, 3.2-blocker)

Hans Wennborg hans at chromium.org
Thu Nov 15 03:45:14 PST 2012


+Pawel: Is there a procedure for getting this onto the 3.2 branch, or
should I just land it there myself?

On Thu, Nov 15, 2012 at 11:07 AM, Nick Lewycky <nicholas at mxc.ca> wrote:
> +    const Constant *C = WorkList.back();
> +    WorkList.pop_back();
>
> const Constant *C = WorkList.pop_back_val();

Done.

> +      if (!Visited.count(D)) {
> +        WorkList.push_back(D);
> +        Visited.insert(C);
> +      }
> '
> if (Visited.insert(D)) {
>   WorkList.push_back(D);
> }

Done.

> LGTM!

Thanks! Landed r168037.

 - Hans



More information about the llvm-commits mailing list