[llvm-commits] [PATCH] some cleanup in DataLayout

[Patrik Hägglund H]

Thanks,

Patch 1 commited as 167924.

I will take a second look at VoidTyID.

/Patrik Hägglund

-----Original Message-----
From: Chris Lattner [mailto:clattner at apple.com] 
Sent: den 14 november 2012 08:02
To: Patrik Hägglund H
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] [PATCH] some cleanup in DataLayout


On Nov 13, 2012, at 5:00 AM, Patrik Hägglund H <patrik.h.hagglund at ericsson.com> wrote:

> Here are two minor cleanup patches for DataLayout. (Found during preparing a series of patches for non-8-bit bytes.)
> 
> Subject: [PATCH 1/2] Revert some redundant parts of r142605.
> 
> This seems like redundant leftovers from r142288 - exposing
> TargetData::parseSpecifier to LLParser - which got reverted. Removes
> redunant td != NULL checks in parseSpecifier, and simplifies the
> interface to parseSpecifier and init.

Looks great to me,

> Subject: [PATCH 2/2] Change size of VoidTyID from 8 to 0 bits.
> 
> According to Type.h, VoidTyID is a "type with no size".

 This makes less sense.  Asking for the size of void is nonsensical, and void can only be the result of a function.  I'd rather that this function abort when asked for the size of void, but we'd obviously need to update the docs for the API and make sure no tests fail due to that.

-Chris