[llvm-commits] [llvm] r167894 - /llvm/trunk/lib/Object/Archive.cpp

[Duncan Sands]

Hi Matt,

On 14/11/12 01:21, Matt Beaumont-Gay wrote:
> Author: matthewbg
> Date: Tue Nov 13 18:21:27 2012
> New Revision: 167894
>
> URL: http://llvm.org/viewvc/llvm-project?rev=167894&view=rev
> Log:
> Fix broken asserts. Also, spell 'indices' correctly.
>
> Modified:
>      llvm/trunk/lib/Object/Archive.cpp
>
> Modified: llvm/trunk/lib/Object/Archive.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Object/Archive.cpp?rev=167894&r1=167893&r2=167894&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Object/Archive.cpp (original)
> +++ llvm/trunk/lib/Object/Archive.cpp Tue Nov 13 18:21:27 2012
> @@ -272,7 +272,7 @@
>       Offset = *(reinterpret_cast<const support::ubig32_t*>(Offsets)
>                  + SymbolIndex);
>     } else if (Parent->kind() == K_BSD) {
> -    assert("BSD format is not supported");
> +    assert(0 && "BSD format is not supported");

the LLVM style is to use
   llvm_unreachable("BSD format is not supported");
for this kind of thing.

>     } else {
>       uint32_t MemberCount = *reinterpret_cast<const support::ulittle32_t*>(Buf);
>

Ciao, Duncan.