[llvm-commits] Configure patch. CXXFLAGS and CFLAGS option doesn't works. Also we need BUILD_CXXFLAGS and BUILD_CFLAGS

[Stepan Dyatkovskiy]

So... was that LGTM? Can I commit this patch?

Andrew Trick wrote:
>
> On Nov 13, 2012, at 2:19 PM, Eric Christopher <echristo at gmail.com
> <mailto:echristo at gmail.com>> wrote:
>
>> FWIW c++11 can be done via configure flag, same with libc++ :)
>
> Now you tell me...
>
> Anyway, our Makefile docs state that CXXFLAGS is a configure override,
> so this patch looks like a good fix to me.
>
> -Andy
>
>> On Tue, Nov 13, 2012 at 1:31 PM, Andrew Trick <atrick at apple.com
>> <mailto:atrick at apple.com>> wrote:
>>
>>     On Nov 7, 2012, at 8:16 PM, Stepan Dyatkovskiy <STPWORLD at narod.ru
>>     <mailto:STPWORLD at narod.ru>> wrote:
>>
>>     > Hi!
>>     > CFLAGS and CXXFLAGS are not substituted in Makefile.config.in
>>     <http://makefile.config.in/>.
>>     > Also it would be good to customize CFLAGS, CXXFLAGS and LDFLAGS
>>     for build platform while doing cross-compilation.
>>     > Please review the patch in attachment.
>>     > -Stepan.
>>
>>     Thanks! This kept me from moving to c++11, which I have to do very
>>     selectively.
>>
>>     I didn't try your cross-compiler options, but it seems simple enough.
>>
>>     -Andy
>>
>>     _______________________________________________
>>     llvm-commits mailing list
>>     llvm-commits at cs.uiuc.edu <mailto:llvm-commits at cs.uiuc.edu>
>>     http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>>
>