[llvm-commits] [llvm] r167860 - in /llvm/trunk/lib/Target/PowerPC: PPCInstr64Bit.td PPCInstrFormats.td PPCInstrInfo.td

Chris Lattner clattner at apple.com
Tue Nov 13 15:31:31 PST 2012


On Nov 13, 2012, at 12:10 PM, Chandler Carruth <chandlerc at google.com> wrote:

> On Tue, Nov 13, 2012 at 11:14 AM, Ulrich Weigand
> <ulrich.weigand at de.ibm.com> wrote:
>> Author: uweigand
>> Date: Tue Nov 13 13:14:19 2012
>> New Revision: 167860
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=167860&view=rev
>> Log:
>> Fix instruction encoding for "isel" on PowerPC,
>> using a new instruction format AForm_4.
> 
> This is another patch that needs test cases.
> 
> I'm continuing to comment on these patches as I would like to make
> sure that eventually (once the infrastructure problems are addressed)
> you come back to each of these and provide test cases so we don't
> regress. The fixes are really important, but I fear we will just break
> them again unless we are very rigorous in the testing...

Ulrich, is the PowerPC backend wired up into llvm-mc?  If so, you should be able to write a testcase along the lines of test/MC/X86/x86_64-encoding.s .

-Chris





More information about the llvm-commits mailing list