[llvm-commits] [PATCH, PowerPC] Add test case (was: r167864 - in /llvm/trunk: include/llvm/Support/ELF.h lib/Target/PowerPC/MCTargetDesc/PPCELFObjectWriter.cpp)

Ulrich Weigand Ulrich.Weigand at de.ibm.com
Tue Nov 13 12:58:39 PST 2012


> Chandler Carruth <chandlerc at google.com> wrote on 13.11.2012 21:05:38:
>
> > > URL: http://llvm.org/viewvc/llvm-project?rev=167864&view=rev
> > > Log:
> > > Add (some) PowerPC TLS relocation types to ELF.h and
> > > generate them from PPCELFObjectWriter::getRelocTypeInner
> > > as appropriate.
> >
> > Is this fixing a JIT test that is currently failing on PPC hosts? If
> > so, please mention it with the commit so folks understand that is how
> > it is being tested. If not, a new test case to cover this seems
> > useful.
>
> Well, it fixes the TLS tests in test-suite:
> SingleSource/UnitTests/Threads/2010-12-08-tls
> SingleSource/UnitTests/Threads/tls
> when using clang with the integrated assembler on PowerPC.
>
> But for this particular patch, it may be feasible to construct a test
> even without having the asm parser in place, something along the lines
> of test/MC/PowerPC/ppc64-relocs-01.ll.  I'll work on that.

OK, here's the test case; turned out to be rather straightforward.
Sorry for not adding this right away.

OK to commit?

Bye,
Ulrich

(See attached file: diff-llvm-mc-tprel-test)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: diff-llvm-mc-tprel-test
Type: application/octet-stream
Size: 1059 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121113/330f627d/attachment.obj>


More information about the llvm-commits mailing list