[llvm-commits] [PATCH] some cleanup in DataLayout

[Villmow, Micah]

The first one looks fine to me. Not sure about the second. Seems changing size of void to 0 size is fine, but not sure about its implications in the rest of the code base.

Micah

> -----Original Message-----
> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> bounces at cs.uiuc.edu] On Behalf Of Patrik Hägglund H
> Sent: Tuesday, November 13, 2012 5:01 AM
> To: llvm-commits at cs.uiuc.edu
> Subject: [llvm-commits] [PATCH] some cleanup in DataLayout
> 
> Here are two minor cleanup patches for DataLayout. (Found during
> preparing a series of patches for non-8-bit bytes.)
> 
> Subject: [PATCH 1/2] Revert some redundant parts of r142605.
> 
> This seems like redundant leftovers from r142288 - exposing
> TargetData::parseSpecifier to LLParser - which got reverted. Removes
> redunant td != NULL checks in parseSpecifier, and simplifies the
> interface to parseSpecifier and init.
> ---
>  include/llvm/DataLayout.h | 20 ++++++++------------
> lib/VMCore/DataLayout.cpp | 36 +++++++++++++++---------------------
>  2 files changed, 23 insertions(+), 33 deletions(-)
> 
> 
> Subject: [PATCH 2/2] Change size of VoidTyID from 8 to 0 bits.
> 
> According to Type.h, VoidTyID is a "type with no size".
> ---
>  lib/VMCore/DataLayout.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> Regards,
> Patrik Hägglund