[llvm-commits] RFC: new tool: llvm-strings

[Marshall Clow]

On Nov 12, 2012, at 12:58 PM, Eric Christopher <echristo at gmail.com> wrote:
> On Mon, Nov 12, 2012 at 7:58 AM, Marshall Clow <mclow.lists at gmail.com> wrote:
> Here's a first cut at a "strings" tool for LLVM.
> 
> It is currently missing one feature: the ability to dump the strings from a single object file in an archive.
> There are also some 80 column style violations in the source.
> 
> I'll be fixing both of those and re-posting soon - but I'm posting now this to get feedback - to see if anyone thinks that I'm missing (any other) stuff.
> 
> Tabs, oh god the tabs.

To spare Eric the agony, I have:
	* removed all the tabs
	* cleaned up a bunch of style violations
	* implemented the feature to dump only the contents of one object file in an archive.

Micheal wrote:
>  The only concern I have is structuring FindStringsInBlob so that implementing --encoding is easy.

This comment sailed right by me, Michael :-(

-- Marshall

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121113/fa4a2e13/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvm-strings.patch2
Type: application/octet-stream
Size: 13386 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121113/fa4a2e13/attachment.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121113/fa4a2e13/attachment-0001.html>