[llvm-commits] [PATCH] Support for [[@LINE]], [[@LINE+<offset>]], [[@LINE-<offset>]] expressions in FileCheck

[Dmitri Gribenko]

  Thank you for working on this!

  These are mostly minor comments.

  Please add information about this feature to docs/CommandGuide/FileCheck.rst.


================
Comment at: utils/FileCheck/FileCheck.cpp:68
@@ +67,3 @@
+  /// \brief Contains the number of line this pattern is in.
+  int LineNumber;
+
----------------
Line numbers are usually stored as 'unsigned'.  (Here and a few cases below.)

================
Comment at: utils/FileCheck/FileCheck.cpp:204
@@ -195,2 +203,3 @@
 
       // Verify that the name is well formed.
+      bool IsExpression = false;
----------------
This makes 'Name' a bit of a misnomer...

Please expand comment to include that name can also be an expression of the form @foo, @foo+something, @foo-something.

================
Comment at: utils/FileCheck/FileCheck.cpp:112
@@ -107,1 +111,3 @@
+
+  bool EvaluateExpression(StringRef Expr, std::string &Value) const;
 };
----------------
Please document the return value (true is success).


http://llvm-reviews.chandlerc.com/D109