[llvm-commits] [llvm] r167793 - in /llvm/trunk: lib/CodeGen/RegisterCoalescer.cpp test/CodeGen/ARM/coalesce-subregs.ll

[Andrew Trick]

Author: atrick
Date: Mon Nov 12 18:34:44 2012
New Revision: 167793

URL: http://llvm.org/viewvc/llvm-project?rev=167793&view=rev
Log:
Cleanup the main RegisterCoalescer loop.

Block priorities still apply outside loops.

Modified:
    llvm/trunk/lib/CodeGen/RegisterCoalescer.cpp
    llvm/trunk/test/CodeGen/ARM/coalesce-subregs.ll

Modified: llvm/trunk/lib/CodeGen/RegisterCoalescer.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/RegisterCoalescer.cpp?rev=167793&r1=167792&r2=167793&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/RegisterCoalescer.cpp (original)
+++ llvm/trunk/lib/CodeGen/RegisterCoalescer.cpp Mon Nov 12 18:34:44 2012
@@ -2001,30 +2001,17 @@
   DEBUG(dbgs() << "********** JOINING INTERVALS ***********\n");
   assert(WorkList.empty() && "Old data still around.");
 
-  if (Loops->empty()) {
-    // If there are no loops in the function, join intervals in function order.
-    for (MachineFunction::iterator I = MF->begin(), E = MF->end();
-         I != E; ++I)
-      copyCoalesceInMBB(I);
-  } else {
-    // Otherwise, join intervals in inner loops before other intervals.
-    // Unfortunately we can't just iterate over loop hierarchy here because
-    // there may be more MBB's than BB's.  Collect MBB's for sorting.
-
-    // Join intervals in the function prolog first. We want to join physical
-    // registers with virtual registers before the intervals got too long.
-    std::vector<MBBPriorityInfo> MBBs;
-    for (MachineFunction::iterator I = MF->begin(), E = MF->end();I != E;++I){
-      MachineBasicBlock *MBB = I;
-      MBBs.push_back(MBBPriorityInfo(MBB, Loops->getLoopDepth(MBB),
-                                     isSplitEdge(MBB)));
-    }
-    std::sort(MBBs.begin(), MBBs.end(), MBBPriorityCompare());
-
-    // Finally, join intervals in loop nest order.
-    for (unsigned i = 0, e = MBBs.size(); i != e; ++i)
-      copyCoalesceInMBB(MBBs[i].MBB);
+  std::vector<MBBPriorityInfo> MBBs;
+  for (MachineFunction::iterator I = MF->begin(), E = MF->end();I != E;++I){
+    MachineBasicBlock *MBB = I;
+    MBBs.push_back(MBBPriorityInfo(MBB, Loops->getLoopDepth(MBB),
+                                   isSplitEdge(MBB)));
   }
+  std::sort(MBBs.begin(), MBBs.end(), MBBPriorityCompare());
+
+  // Coalesce intervals in MBB priority order.
+  for (unsigned i = 0, e = MBBs.size(); i != e; ++i)
+    copyCoalesceInMBB(MBBs[i].MBB);
 
   // Joining intervals can allow other intervals to be joined.  Iteratively join
   // until we make no progress.

Modified: llvm/trunk/test/CodeGen/ARM/coalesce-subregs.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/coalesce-subregs.ll?rev=167793&r1=167792&r2=167793&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/ARM/coalesce-subregs.ll (original)
+++ llvm/trunk/test/CodeGen/ARM/coalesce-subregs.ll Mon Nov 12 18:34:44 2012
@@ -147,7 +147,7 @@
 ; CHECK: vmov.f32 {{.*}}, #1.0
 ; CHECK-NOT: vmov
 ; CHECK-NOT: vorr
-; CHECK: %if.end
+; CHECK: bx
 ; We may leave the last insertelement in the if.end block.
 ; It is inserting the %add value into a dead lane, but %add causes interference
 ; in the entry block, and we don't do dead lane checks across basic blocks.