[llvm-commits] RFC: new tool: llvm-strings

[Michael Spencer]

On Mon, Nov 12, 2012 at 7:58 AM, Marshall Clow <mclow.lists at gmail.com> wrote:
> Here's a first cut at a "strings" tool for LLVM.
>
> It is currently missing one feature: the ability to dump the strings from a single object file in an archive.
> There are also some 80 column style violations in the source.
>
> I'll be fixing both of those and re-posting soon - but I'm posting now this to get feedback - to see if anyone thinks that I'm missing (any other) stuff.
>
> Thanks!
>
> -- Marshall

+//===-- llvm-strings.cpp - Symbol table dumping utility for llvm
----------===//

Is wrong.

There are also a lot more style violations than just 80-col. But other
than that it looks fine. The only concern I have is structuring
FindStringsInBlob so that implementing --encoding is easy.

- Michael Spencer