[llvm-commits] [PATCH] Remove llvm-symbolizer from compiler-rt/utils

Alexander Potapenko glider at google.com
Mon Nov 12 03:35:11 PST 2012


r167722, thank you!

On Mon, Nov 12, 2012 at 12:24 PM, Alexey Samsonov <samsonov at google.com> wrote:
>
>   Looks good.
>
>
> ================
> Comment at: lib/asan/lit_tests/lit.cfg:73
> @@ -72,2 +72,3 @@
>  if llvm_obj_root:
>    config.environment['LLVM_SYMBOLIZER_PATH'] = os.path.join(
> +      config.llvm_obj_root, "bin", "llvm-symbolizer")
> ----------------
> When llvm-symbolizer is an llvm tool you may rewrite this piece as follows:
> llvm_tools_dir = getattr(config, 'llvm_tools_dir', None)
> if llvm_tools_dir:
>   .... = os.path.join(llvm_tools_dir, "llvm-symbolizer")
>
>
> http://llvm-reviews.chandlerc.com/D108



-- 
Alexander Potapenko
Software Engineer
Google Moscow



More information about the llvm-commits mailing list