[llvm-commits] [PATCH 2/2] instcombine: Query target library information for libcall simplifications

[Meador Inge]

On 11/08/2012 07:34 PM, Eli Friedman wrote:

> On Thu, Nov 8, 2012 at 2:21 PM, Meador Inge <meadori at codesourcery.com> wrote:
>> Several of the simplifiers migrated from the simplify-libcalls pass to
>> the instcombine pass were not correctly checking the target library
>> information to gate the simplifications.  This patch ensures that the
>> check is made.  Corresponding tests that exercise the -fno-builtin option
>> will be added to the clang test suite.
> 
> Can you test with opt? (you might need to add a -fno-builtin equivalent flag.)

Yup, there is a -disable-simplify-libcalls switch on opt.  I will add those
tests before committing.

> Otherwise, LGTM.

Thanks for the review!

-- 
Meador Inge
CodeSourcery / Mentor Embedded
http://www.mentor.com/embedded-software