[llvm-commits] [TableGen] Invalid flat operand number

[Evandro Menezes]

On 11/07/12 14:30, Evandro Menezes wrote:
> On 11/07/12 13:05, Bill Wendling wrote:
>> You shouldn't be recalculating the size of 'CGI.Operands' for each 
>> iteration of the loop. I'm also concerned about that value of 
>> NumberedOp once this returns. How does it being '>= CGI.Operands' 
>> affect the caller of this method? -bw 
>
> I can cache the size of CGI.Operands.
>
> This method is private and its only caller ignores the result of 
> NumberedOp.  However, in my reading of it, its purpose is to count the 
> number of matched operands, so the cap seems legit.

Does it look OK now?

Thanks,

-- 
Evandro Menezes          Austin, TX          emenezes at codeaurora.org
Qualcomm Innovation Center, Inc is a member of the Code Aurora Forum