[llvm-commits] [PATCH] instcombine: wire up -fno-builtin to the library call simplifier

[Eli Friedman]

On Wed, Nov 7, 2012 at 8:24 PM, Meador Inge <meadori at codesourcery.com> wrote:
> Now that the library call simplifiers are being migrated out of their own
> pass into the instruction combiner pass the latter needs to be modified to
> work with -fno-builtin.  This is accomplished by adding a new parameter
> to the InstCombiner constructor and to the createInstructionCombiningPass
> factory function that controls whether library call simplification should
> be performed or not.  The pass manager already has an option to control
> library call simplification.  This option is now passed through when creating
> instances of the instruction combiner class.
>
> OK?

It would be better if you could just fix the code in question so it
uses TargetLibraryInfo correctly.

Also, testcase please.

-Eli