[llvm-commits] [PATCH] basic reading reloc visitor for x86_64 ELF

[Eric Christopher]

On Tue, Nov 6, 2012 at 9:17 AM, Eli Bendersky <eliben at google.com> wrote:

> >> >
> >>
> >> A slightly expanded version of this will make for a great comment in
> >> the code :-) Seriously, please document the purpose of the new
> >> relocMap data structure you're adding.
> >>
> >
> > Uh hey, good point. Done :)
>
> Great. At the moment I get a mental Parse Error when reading the
> comment (especially the first sentence), though. I'll try to find time
> to study the code better a bit later, maybe it will make the error go
> away.
>
>
I'll reread it a bit and see if I can make it more clear.


>
> Hmm, I don't know if it makes sense to flatten out all info about
> every section like this. DWARF relocations can appear for a number of
> sections and other things may be added in the future. However, it's
> probably not worth over-thinking it at this point as it may be
> refactored later if the need arises.


Agreed, I've got about 4 more sections for just the accelerator tables and
then fission will add a few more. I'm totally up for ways to refactor or
redesign all of this to make sense. I played with it for a couple days and
let my desire to avoid allocating 3GB of RAM just to dump a file take
priority. That said, I'd be up for anything reasonable that feels better.

Thanks for the comments!

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121106/0d795b98/attachment.html>