[llvm-commits] [PATCH] Always append -XXXXXX in Path::makeUnique , fixes bug 13511

[Jordy Potman]

Hi,

Path::makeUnique fails if a directory with the same name as the path
that has to be made unique already exists and that directory is not
writable, because it tries to make a subdirectory in that directory. See
bug 13511 [1].

The attached patch fixes this by removing the directory test so -XXXXXX
is always appended to the path, because I personally do not see the need
for making directories a special case. The special case for directories
was introduced in revision 53929 [2], but the commit message does not
explain why.

I have ran the nightly test suite with the patch applied and I do not
see any differences in the test results compared to the test results
without the patch.

Please review the patch and commit it if it looks good.

Thanks,

Jordy

[1] http://llvm.org/bugs/show_bug.cgi?id=13511
[2] http://llvm.org/viewvc/llvm-project?view=rev&revision=53929

-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-llvm-bug-13511.patch
Type: text/x-patch
Size: 590 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121106/1c47cea0/attachment.bin>