[llvm-commits] [lld] r167254 - /lld/trunk/lib/ReaderWriter/MachO/WriterMachO.cpp

[Rafael Espíndola]

> rename dylibNamesToOrdinal now that it is an ivar

Is this a lld variation on the llvm style? The llvm coding standard
says nothing about adding leading underscores to members.

> Modified:
>     lld/trunk/lib/ReaderWriter/MachO/WriterMachO.cpp
>
> Modified: lld/trunk/lib/ReaderWriter/MachO/WriterMachO.cpp
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/MachO/WriterMachO.cpp?rev=167254&r1=167253&r2=167254&view=diff
> ==============================================================================
> --- lld/trunk/lib/ReaderWriter/MachO/WriterMachO.cpp (original)
> +++ lld/trunk/lib/ReaderWriter/MachO/WriterMachO.cpp Thu Nov  1 16:44:45 2012
> @@ -206,7 +206,7 @@
>    dyld_info_command           *_dyldInfoLoadCommand;
>    std::vector<load_command*>   _loadCmds;
>    std::vector<ChunkSegInfo>    _sectionInfo;
> -  llvm::StringMap<uint32_t> dylibNamesToOrdinal;
> +  llvm::StringMap<uint32_t>    _dylibNamesToOrdinal;
>  };
>
>
> @@ -777,13 +777,13 @@
>    // Add dylib load commands.
>    for (const SharedLibraryAtom* shlibAtom : file.sharedLibrary() ) {
>      StringRef installName = shlibAtom->loadName();
> -    if ( dylibNamesToOrdinal.count(installName) == 0 ) {
> -      uint32_t ord = dylibNamesToOrdinal.size();
> -      dylibNamesToOrdinal[installName] = ord;
> +    if ( _dylibNamesToOrdinal.count(installName) == 0 ) {
> +      uint32_t ord = _dylibNamesToOrdinal.size();
> +      _dylibNamesToOrdinal[installName] = ord;
>      }
>    }
> -  for (llvm::StringMap<uint32_t>::iterator it=dylibNamesToOrdinal.begin(),
> -                            end=dylibNamesToOrdinal.end(); it != end; ++it) {
> +  for (llvm::StringMap<uint32_t>::iterator it=_dylibNamesToOrdinal.begin(),
> +                            end=_dylibNamesToOrdinal.end(); it != end; ++it) {
>      this->addLoadCommand(new dylib_command(it->first(), is64));
>    }
>

Cheers,
Rafael