[llvm-commits] [llvm] r164178 - in /llvm/trunk: lib/Transforms/Scalar/SROA.cpp test/Transforms/SROA/basictest.ll

[Duncan Sands]

Hi Chandler,

>>> --- llvm/trunk/lib/Transforms/Scalar/SROA.cpp (original)
>>> +++ llvm/trunk/lib/Transforms/Scalar/SROA.cpp Tue Sep 18 17:37:19 2012
>>> @@ -1487,6 +1487,8 @@
>>>        return 0;
>>>
>>>      Type *ElementTy = Ty->getElementType();
>>> +  if (!ElementTy->isSized())
>>> +    return 0; // We can't GEP through an unsized element.
>>
>>
>> actually you can, if all the indices are zero.
>
> Saw this in my commit mail backlog...
>
> Is there a concern with the comment, or the functionality here?

I don't really remember, but just the comment I think.

Ciao, Duncan.