[llvm-commits] Patch to add a convenience function in ELF.h

[Eric Christopher]

Hi Shankar,

Couple of thoughts on this:

a) Use case?
b)

   Elf_Xword     st_size;  // Size of the symbol
+
 };

extra whitespace

c)

+  return object_error::parse_failed;

parse failed? Seems like an odd error.

d)

+}
+
+
+template<support::endianness target_endianness, bool is64Bits>

More extra whitespace.

-eric

On Thu, Nov 1, 2012 at 7:26 AM, Shankar Easwaran
<shankare at codeaurora.org> wrote:
> Hi,
>
> This is a patch to add a convenience function in ELF.h to add support for
> getting to the symbol table index given a Elf_Sym.
>
> Thanks
>
> Shankar Easwaran
>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
> the Linux Foundation
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>