[llvm-commits] [PATCH] basicaa - fix miscompilation of load from nocapture attribute (PR14045)

Dan Gohman dan433584 at gmail.com
Fri Nov 2 13:01:54 PDT 2012


Looks good to me. It might be nice to add a comment where the code used to
check for nocapture mentioning that nocapture is being intentionally
ignored.

Dan

On Fri, Nov 2, 2012 at 10:38 AM, Richard Osborne <richard at xmos.com> wrote:

> This is a patch for PR14045.
>
> It is wrong to infer that a value is not captured in the current function
> beacuse it is marked with the 'nocapture' attribute. The nocapture
> attribute only specifies that no copies are made that outlive the function
> which isn't the same as there being no copies at all. Patch includes a
> testcase and passes make check.
>
> OK to commit?
>
> Thanks,
>
> Richard
>
> --
> Richard Osborne | XMOS
> http://www.xmos.com
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121102/e1615397/attachment.html>


More information about the llvm-commits mailing list