[llvm-commits] RFC: Merge branches/R600 into TOT for 3.2 release

[Tom Stellard]

On Thu, Nov 01, 2012 at 09:49:30PM -0700, Chris Lattner wrote:
> On Oct 31, 2012, at 8:09 AM, Tom Stellard <tom at stellard.net> wrote:
> >>> Not counting test cases, new intrinsics, and configuration files,
> >>> there are no changes outside of Target/AMDGPU.  I always submit patches
> >>> for changes I make outside of Target/AMDGPU.  Isn't that how Open Source
> >>> is supposed to work? ;)
> >> 
> >> Well yeah, but sometimes you still have to ask :).  Can the intrinsics be pulled into the target directory ala Targets/MBlaze/MBlazeIntrinsics.td or Targets/NVPTX/NVPTXIntrinsics.td?
> >> 
> > 
> > Actually, most of the intrinsics are defined in Targets/AMDGPU.  The
> > intrinsics I've added in include/llvm/R600Intrinsics.td are for querying
> > work group and work item information that I would like to be able to
> > pair with builtins in clang.  Will clang still be able to find these
> > intrinsics if I move them to Targets/AMDGPU ?
> 
> I don't know off-hand, sorry.
> 
> >> Any way that you can slices it to land it in stages would be preferred.  Another major challenge will be to find someone to review the patch.  You don't need detailed comments on every design aspect, but it is important to give you a basic "yeah, the structure looks fine and there aren't any obviously gratuitous code style violations" is the sort of review I'm looking for.  I'm not sure a great way to get this, but asking on llvmdev is probably a good start.
> >> 
> > 
> > Maybe I can split up the R600 and SI code into separate patches.  This
> > way the patches that land will actually work.
> > 
> > I will continue to ask developers for reviews.  If you are able to
> > poke anyone who you think might be able to review the code, I would
> > appreciate it.
> 
> Great.  Are you going to the developer meeting?  Pinning someone down at the half-day hackers session on next wednesday would be a great way to help get this to happen.
> 

Unfortunately, I'm unable to attend the developer meeting, but I'll hang
around IRC during the hackers session and see if I can find someone to
help with the review.

-Tom