[llvm-commits] [PATCH 4/4] Profile metadata: test-suite Makefiles

[manman ren]

Committed as r167270.

Thanks,
Manman

On Oct 31, 2012, at 10:07 PM, Alastair Murray <alastairmurray42 at gmail.com> wrote:

> Hi Manman,
> 
> On 31/10/12 19:34, manman ren wrote:
>> Last time I tried the combined patch in Sept, I got some error messages.
>> But today, it seems to be working with the whole test-suite including the SPEC external tests.
>> I will try to check it in today or tomorrow.
> 
> I just tried this using Makefile.singlersrc. I overrode the same rule that is overriden in Makefile.spec, and added different echo's to both versions of the rule.  SingleSource benchmarks use the Makefile.singlesrc version, MultiSource benchmarks use the original TEST.profile.Makefile version.   So this is correct behaviour.  There are, however, a lot of warnings issued.  For every benchmark in SingleSource there are warnings like:
> 
> ../../../SingleSource/Makefile.singlesrc:143: warning: overriding recipe for target `Output/Bubblesort.prof-edge-gen.out-pgo'
> 
> /home/alym/llvm/build/Release+Asserts/projects/test-suite/../../../../llvm/projects/test-suite/TEST.profile.Makefile:164: warning: ignoring old recipe for target `Output/Bubblesort.prof-edge-gen.out-pgo'
> 
> Obviously with SPEC the complaints will be about Makefile.spec, and they will only occur for SPEC benchmarks.
> 
> Reading the GNU make manual I don't think there are any negative consequences of this, other than the noise.  It's not ideal though.
> 
> I tried to get rid of the warnings via double-colon rules, but that turned out to be a terrible idea (both versions of the rule execute).
> 
> Regards,
> Alastair.