[llvm-commits] [PATCH 3/4] Profile metadata: runtime support - ping

[Alastair Murray]

Hi all,

Ping (number 2).

If noone objects Manman Ren will commit this patch tomorrow.

Regards,
Alastair.

On 30/10/12 13:58, Alastair Murray wrote:
> Hi all,
>
> Ping on this patch!  (Sorry!)
>
> The patch has no effect at runtime unless the LLVMPROF_OUTPUT
> environment variable is set.
>
> Are there concerns about how it works on Windows?  I haven't tested that
> but the Windows documentation advises against using getenv().
>
> Regards,
> Alastair.
>
> On 18/08/12 09:46, Alastair Murray wrote:
>> Hello all,
>>
>> Please review the attached patch.
>>
>> This is the second of four patches to support setting branch weight
>> metadata by profiling.  It does not depend on the previous patches.
>>
>> This small patch allows the profile data file name to be specified by
>> the LLVMPROF_OUTPUT environment variable.  This allows parallel make for
>> profiling code (to come in patch #4), without it the are file collisions
>> as each parallel run uses the default file name.
>>
>> There is already code in the runtime library to specify the output file
>> name via the command line, but this only works for programs which
>> already process argc/argv.  This patch builds on that support.
>>
>> Regards,
>> Alastair Murray
>
>