[llvm-commits] [LNT] r167072 - /lnt/trunk/lnt/tests/compile.py

[Michael Gottesman]

I do grant that I should have rebased certain of the commits.

On the other hand, all of the commits are related as they are all related to work in the same file which includes cleaning up parts of it and making it less tied in to a specific test case. They are fairly simple since I was following LLVM's philosophy of small simple commits. Also I wrote all of this code yesterday afternoon, so I was ``committing early and often''.

Michael

On Oct 30, 2012, at 9:07 PM, David Blaikie <dblaikie at gmail.com> wrote:

> On Tue, Oct 30, 2012 at 5:14 PM, Michael Gottesman <mgottesman at apple.com> wrote:
>> Author: mgottesman
>> Date: Tue Oct 30 19:14:19 2012
>> New Revision: 167072
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=167072&view=rev
>> Log:
>> [compile test] Fixed typo.
> 
> Many of the changes you've just committed seem unrelated & fairly
> simple - is there a reason you couldn't "commit early, commit often"
> rather than saving them all up to commit in one batch? This approach
> isn't really conducive to collaborative development.
> 
>> Modified:
>>    lnt/trunk/lnt/tests/compile.py
>> 
>> Modified: lnt/trunk/lnt/tests/compile.py
>> URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/tests/compile.py?rev=167072&r1=167071&r2=167072&view=diff
>> ==============================================================================
>> --- lnt/trunk/lnt/tests/compile.py (original)
>> +++ lnt/trunk/lnt/tests/compile.py Tue Oct 30 19:14:19 2012
>> @@ -421,7 +421,7 @@
>> def get_single_file_tests(flags_to_test, test_suite_externals,
>>                           subdir):
>>     # Load the project description file from the externals.
>> -    path = os.path.join(test_suite_externals, test_suite_externals_subdir,
>> +    path = os.path.join(test_suite_externals, subdir,
>>                         "project_list.json")
>>     with open(path) as f:
>>         all_tests = json.load(f).get('single-file', [])
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits