[llvm-commits] [patch] Use %lli instead of lli %defaultjit

[Kaylor, Andrew]

I don't think it's a good idea to put this into the %lli substitution.

The ExecutionEngine tests use that substitution string but also have a separate directory for MCJIT tests which explicitly provide the -use-mcjit option.  If it is provided twice, the tests will fail.  The presence of the current configure code to append -use-mcjit to %lli was an early attempt to provide ExecutionEngine testing on JIT and MCJIT before the secondary directory was created.  It isn't used by the buildbots and should probably go away.  I don't know anything about the mangling of the target triple there.  I'm not sure it does anything.

There is a plan to extend lit to handle multiple runs with different options, which will use the -use-mcjit flag in the ExecutionEngine tests.

For now I think it is better left as it is.

-Andy

-----Original Message-----
From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Rafael Espíndola
Sent: Tuesday, October 30, 2012 7:19 PM
To: llvm-commits
Subject: Re: [llvm-commits] [patch] Use %lli instead of lli %defaultjit

Attached now.

On 30 October 2012 22:19, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
> I think %defaultjit can be replaced by %lli if we set the default jit 
> to be MCJIT for ARM and PorwerPC. Is the attached patch OK?
>
> Cheers,
> Rafael