[llvm-commits] [PATCH] Add a segment type for PT_ARM_EXIDX in llvm/Support/ELF.h

[James Molloy]

Hi Pete,

This patch looks good to me, and I've committed it in r167109.

Cheers!

James

On Tue, 2012-10-30 at 10:05 +0000, pete wrote:
> Hi,
> 
> 
> We can find ARM defined segment types in the chapter 5 of "ELF for the
> ARM
> Architecture", http://infocenter.arm.com/help/topic/com.arm.doc.ihi0044d/IHI0044D_aaelf.pdf
> 
> 
> Table 5-1, Processor-specific segment types 
> Name            p_type      Meaning 
> PT_ARM_ARCHEXT  0x70000000  Platform architecture compatibility
> information
> PT_ARM_EXIDX    0x70000001  Exception unwind tables 
> PT_ARM_UNWIND 
> 
> 
> Will it be better to add all missing constants for ARM segments?
> 
> 
> Thanks,
> Pete
> 
> 
> 
> On Fri, Oct 26, 2012 at 6:13 PM, Pete Chou <petechou at gmail.com> wrote:
>         Hi,
>         
>         
>         This is a patch to add a missing ELF constant for PT_ARM_EXIDX
>         segment. I think any linker project based on LLVM that
>         supports ARM ELF EH will need this. And I made a patch for
>         this (attached add-pt-arm-exidx.diff). Or will it be better if
>         I rearrange the segment constants in the standard first like
>         the attached add-arm-pt-arm-exidx-2.diff?
>         (See http://www.sco.com/developers/gabi/latest/ch5.pheader.html#p_type)
>          
>         Please help review and commit if it looks good.
>         
>         
>         -
>         Thanks,
>         Pete
> 
>