[llvm-commits] [PATCH 4/4] Profile metadata: test-suite Makefiles
Alastair Murray
alastairmurray42 at gmail.com
Tue Oct 30 13:07:20 PDT 2012
Hi Manman, all,
Daniel: I have also CC'ed you on this as you seem to do most of the
test-suite work. If you have no interest in these Makefiles or you feel
they are not suitable for the repository then please let me know.
On 07/09/12 20:54, Manman Ren wrote:
> Alastair, I looked at your test-suite patch for PGO, it needs to be modified to make it work for SPEC (Makefile.spec).
> The modifications are attached.
Manman: I have included your SPEC changes in the patch. I don't have
access to SPEC so I can't test them, but I have visually verified that
your previous patch is still compatible with recent test-suite changes.
> I haven't found time to make it work for both SPEC and other benchmarks.
Manman, I don't understand this statement. The patch as attached works
for test-suite, I assume that you have tested it on SPEC. So it works
for both ...
Otherwise the only change from the previous patch is to switch uses of
$(RUNTOOLSAFELY) over to $(RUNSAFELYLOCAL) to match recent test-suite
changes.
This patch is still dependent on the as-yet unreviewed "[PATCH 3/4]
Profile metadata: runtime support" patch. It could be trivially
rewritten to not depend on that patch, but make -jN would not work for N>1.
Regards,
Alastair.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: weights_4_testsuite_makefiles.patch
Type: text/x-patch
Size: 15348 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121030/2579e8c3/attachment.bin>
More information about the llvm-commits
mailing list