[llvm-commits] [PATCH] Set %defaultjit testsuite flag for PowerPC

Hal Finkel hfinkel at anl.gov
Tue Oct 30 10:58:00 PDT 2012


----- Original Message -----
> From: "Ulrich Weigand" <Ulrich.Weigand at de.ibm.com>
> To: llvm-commits at cs.uiuc.edu
> Sent: Tuesday, October 30, 2012 12:26:31 PM
> Subject: [llvm-commits] [PATCH] Set %defaultjit testsuite flag for PowerPC
> 
> 
> Hello,
> 
> David Tweed recently provided a patch to allow using MCJit instead of
> the
> old JIT for those tests outside of the ExecutionEngine test suite
> that use
> execution testing.  This is enabled by default for ARM targets.
> 
> Since we are in the same situation on PowerPC (the MCJit works quite
> well
> now that Adhemerval's patches are in, but the old JIT seems rather
> broken),
> I'd like to enable this on PowerPC as well.   The attached patch sets
> %defaultjit to use the MCJit on PowerPC targets, and also adds use of
> %defaultjit to one test case where it is currently missing.
> 
> This fixes the following set of testsuite failures on PowerPC:
>     LLVM :: Analysis/Profiling/load-branch-weights-ifs.ll
>     LLVM :: Analysis/Profiling/load-branch-weights-loops.ll
>     LLVM :: Analysis/Profiling/load-branch-weights-switches.ll
>     LLVM :: Transforms/LICM/2003-12-11-SinkingToPHI.ll
> 
> OK to commit?

MCJIT certainly works better now than the old JIT, and is definitely where we should be focusing our test coverage.
LGTM.

Thanks again,
Hal

> 
> Bye,
> Ulrich
> 
> (See attached file: diff-llvm-defaultjit-ppc)
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 

-- 
Hal Finkel
Postdoctoral Appointee
Leadership Computing Facility
Argonne National Laboratory



More information about the llvm-commits mailing list