[llvm-commits] [test-suite] r166831 - in /test-suite/trunk: External/SPEC/CINT2000/186.crafty/Makefile tools/TargetConfig.mk.in

[Daniel Dunbar]

Hi Lang,

On Fri, Oct 26, 2012 at 4:06 PM, Lang Hames <lhames at gmail.com> wrote:
> Author: lhames
> Date: Fri Oct 26 18:06:41 2012
> New Revision: 166831
>
> URL: http://llvm.org/viewvc/llvm-project?rev=166831&view=rev
> Log:
> Auto-derive another SPEC define from the compiler's built-in defines.
>
> Modified:
>     test-suite/trunk/External/SPEC/CINT2000/186.crafty/Makefile
>     test-suite/trunk/tools/TargetConfig.mk.in
>
> Modified: test-suite/trunk/External/SPEC/CINT2000/186.crafty/Makefile
> URL: http://llvm.org/viewvc/llvm-project/test-suite/trunk/External/SPEC/CINT2000/186.crafty/Makefile?rev=166831&r1=166830&r2=166831&view=diff
> ==============================================================================
> --- test-suite/trunk/External/SPEC/CINT2000/186.crafty/Makefile (original)
> +++ test-suite/trunk/External/SPEC/CINT2000/186.crafty/Makefile Fri Oct 26 18:06:41 2012
> @@ -13,14 +13,15 @@
>
>  include $(LEVEL)/Makefile.config
>
> +ifdef ARCH_HAS_LONGLONG
> +  CPPFLAGS += -DHAS_LONGLONG
> +endif
> +
>  ifeq ($(ARCH),Alpha)
>    CPPFLAGS += -DALPHA -DLINUX
>  endif
> -ifeq ($(ARCH),x86)
> -  CPPFLAGS += -DHAS_LONGLONG
> -endif
>  ifeq ($(ARCH),x86_64)
> -  CPPFLAGS += -DLONG_HAS_64BITS -DHAS_LONGLONG
> +  CPPFLAGS += -DLONG_HAS_64BITS
>  endif
>  ifeq ($(ARCH),PowerPC)
>     CPPFLAGS += -DLINUX_PPC32
> @@ -28,12 +29,6 @@
>  ifeq ($(ARCH),Sparc)
>     CPPFLAGS += -DSUN_BSD
>  endif
> -ifeq ($(ARCH),ARM)
> -  CPPFLAGS += -DHAS_LONGLONG
> -endif
> -ifeq ($(ARCH),THUMB)
> -  CPPFLAGS += -DHAS_LONGLONG
> -endif
>  ifeq ($(TARGET_OS),Darwin)
>    CPPFLAGS += -DUNIX -DLINUX
>  endif
>
> Modified: test-suite/trunk/tools/TargetConfig.mk.in
> URL: http://llvm.org/viewvc/llvm-project/test-suite/trunk/tools/TargetConfig.mk.in?rev=166831&r1=166830&r2=166831&view=diff
> ==============================================================================
> --- test-suite/trunk/tools/TargetConfig.mk.in (original)
> +++ test-suite/trunk/tools/TargetConfig.mk.in Fri Oct 26 18:06:41 2012
> @@ -5,6 +5,7 @@
>
>  #ifdef __LP64__
>  ARCH_LP64 := YES
> +ARCH_HAS_LONGLONG := YES

Is this really right? HAS_LONGLONG doesn't have anything to do with
whether or not the platform is LP64. If you check against your changes
to the crafty Makefile you will see HAS_LONGLONG used to get set in
many more places.

 - Daniel

>  #endif
>
>  #ifdef __LITTLE_ENDIAN__
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits