[llvm-commits] [llvm] r166864 - in /llvm/trunk: include/llvm/Target/TargetLowering.h lib/Transforms/Vectorize/LoopVectorize.cpp test/Transforms/LoopVectorize/X86/gcc-examples.ll
Stepan Dyatkovskiy
stpworld at narod.ru
Sat Oct 27 04:31:33 PDT 2012
Hello, Nadav.
I compiled debug version of llvm under i386 with gcc-4.5.2, and got 11
loop vectorize failures:
Failing Tests (11):
LLVM :: Transforms/LoopVectorize/2012-10-22-isconsec.ll
LLVM :: Transforms/LoopVectorize/X86/cost-model.ll
LLVM :: Transforms/LoopVectorize/X86/gcc-examples.ll
LLVM :: Transforms/LoopVectorize/cpp-new-array.ll
LLVM :: Transforms/LoopVectorize/gcc-examples.ll
LLVM :: Transforms/LoopVectorize/increment.ll
LLVM :: Transforms/LoopVectorize/induction_plus.ll
LLVM :: Transforms/LoopVectorize/non-const-n.ll
LLVM :: Transforms/LoopVectorize/read-only.ll
LLVM :: Transforms/LoopVectorize/reduction.ll
LLVM :: Transforms/LoopVectorize/scalar-select.ll
Stdout of "make check-lit VERBOSE=1" is in attachment.
Let me know, if you need more details.
-Stepan.
Nadav Rotem wrote:
> Author: nadav
> Date: Fri Oct 26 23:11:32 2012
> New Revision: 166864
>
> URL: http://llvm.org/viewvc/llvm-project?rev=166864&view=rev
> Log:
>
> 1. Fix a bug in getTypeConversion. When a *simple* type is split, we need to return the type of the split result.
> 2. Change the maximum vectorization width from 4 to 8.
> 3. A test for both.
>
>
> Added:
> llvm/trunk/test/Transforms/LoopVectorize/X86/gcc-examples.ll
> Modified:
> llvm/trunk/include/llvm/Target/TargetLowering.h
> llvm/trunk/lib/Transforms/Vectorize/LoopVectorize.cpp
>
> Modified: llvm/trunk/include/llvm/Target/TargetLowering.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Target/TargetLowering.h?rev=166864&r1=166863&r2=166864&view=diff
> ==============================================================================
> --- llvm/trunk/include/llvm/Target/TargetLowering.h (original)
> +++ llvm/trunk/include/llvm/Target/TargetLowering.h Fri Oct 26 23:11:32 2012
> @@ -1980,6 +1980,9 @@
> ValueTypeActions.getTypeAction(NVT.getSimpleVT()) != TypePromoteInteger)
> && "Promote may not follow Expand or Promote");
>
> + if (LA == TypeSplitVector)
> + NVT = EVT::getVectorVT(Context, VT.getVectorElementType(),
> + VT.getVectorNumElements() / 2);
> return LegalizeKind(LA, NVT);
> }
>
>
> Modified: llvm/trunk/lib/Transforms/Vectorize/LoopVectorize.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Vectorize/LoopVectorize.cpp?rev=166864&r1=166863&r2=166864&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Transforms/Vectorize/LoopVectorize.cpp (original)
> +++ llvm/trunk/lib/Transforms/Vectorize/LoopVectorize.cpp Fri Oct 26 23:11:32 2012
> @@ -317,7 +317,7 @@
> /// Returns the most profitable vectorization factor for the loop that is
> /// smaller or equal to the VF argument. This method checks every power
> /// of two up to VF.
> - unsigned findBestVectorizationFactor(unsigned VF = 4);
> + unsigned findBestVectorizationFactor(unsigned VF = 8);
>
> private:
> /// Returns the expected execution cost. The unit of the cost does
>
> Added: llvm/trunk/test/Transforms/LoopVectorize/X86/gcc-examples.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/LoopVectorize/X86/gcc-examples.ll?rev=166864&view=auto
> ==============================================================================
> --- llvm/trunk/test/Transforms/LoopVectorize/X86/gcc-examples.ll (added)
> +++ llvm/trunk/test/Transforms/LoopVectorize/X86/gcc-examples.ll Fri Oct 26 23:11:32 2012
> @@ -0,0 +1,62 @@
> +; RUN: opt < %s -loop-vectorize -mtriple=x86_64-apple-macosx10.8.0 -mcpu=corei7 -dce -instcombine -licm -S | FileCheck %s
> +
> +target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64-S128"
> +target triple = "x86_64-apple-macosx10.8.0"
> +
> + at b = common global [2048 x i32] zeroinitializer, align 16
> + at c = common global [2048 x i32] zeroinitializer, align 16
> + at a = common global [2048 x i32] zeroinitializer, align 16
> +
> +; Select VF = 8;
> +;CHECK: @example1
> +;CHECK: load <8 x i32>
> +;CHECK: add <8 x i32>
> +;CHECK: store <8 x i32>
> +;CHECK: ret void
> +define void @example1() nounwind uwtable ssp {
> + br label %1
> +
> +; <label>:1 ; preds = %1, %0
> + %indvars.iv = phi i64 [ 0, %0 ], [ %indvars.iv.next, %1 ]
> + %2 = getelementptr inbounds [2048 x i32]* @b, i64 0, i64 %indvars.iv
> + %3 = load i32* %2, align 4
> + %4 = getelementptr inbounds [2048 x i32]* @c, i64 0, i64 %indvars.iv
> + %5 = load i32* %4, align 4
> + %6 = add nsw i32 %5, %3
> + %7 = getelementptr inbounds [2048 x i32]* @a, i64 0, i64 %indvars.iv
> + store i32 %6, i32* %7, align 4
> + %indvars.iv.next = add i64 %indvars.iv, 1
> + %lftr.wideiv = trunc i64 %indvars.iv.next to i32
> + %exitcond = icmp eq i32 %lftr.wideiv, 256
> + br i1 %exitcond, label %8, label %1
> +
> +; <label>:8 ; preds = %1
> + ret void
> +}
> +
> +
> +; Select VF=4 because sext <8 x i1> to <8 x i32> is expensive.
> +;CHECK: @example10b
> +;CHECK: load <4 x i16>
> +;CHECK: sext <4 x i16>
> +;CHECK: store <4 x i32>
> +;CHECK: ret void
> +define void @example10b(i16* noalias nocapture %sa, i16* noalias nocapture %sb, i16* noalias nocapture %sc, i32* noalias nocapture %ia, i32* noalias nocapture %ib, i32* noalias nocapture %ic) nounwind uwtable ssp {
> + br label %1
> +
> +; <label>:1 ; preds = %1, %0
> + %indvars.iv = phi i64 [ 0, %0 ], [ %indvars.iv.next, %1 ]
> + %2 = getelementptr inbounds i16* %sb, i64 %indvars.iv
> + %3 = load i16* %2, align 2
> + %4 = sext i16 %3 to i32
> + %5 = getelementptr inbounds i32* %ia, i64 %indvars.iv
> + store i32 %4, i32* %5, align 4
> + %indvars.iv.next = add i64 %indvars.iv, 1
> + %lftr.wideiv = trunc i64 %indvars.iv.next to i32
> + %exitcond = icmp eq i32 %lftr.wideiv, 1024
> + br i1 %exitcond, label %6, label %1
> +
> +; <label>:6 ; preds = %1
> + ret void
> +}
> +
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: make-check-lit-stdout.tgz
Type: application/x-compressed-tar
Size: 76861 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20121027/8deb2f01/attachment.bin>
More information about the llvm-commits
mailing list