[llvm-commits] [llvm] r166780 - /llvm/trunk/lib/Target/Mips/Mips16InstrInfo.td

[reed kotler]

On 10/26/2012 10:16 AM, David Blaikie wrote:
> On Fri, Oct 26, 2012 at 9:48 AM, reed kotler <rkotler at mips.com> wrote:
>> The checkin message did not come through.
>>
>> This corrects the distinction between formats FRR16 and FUnaryRR16 for Neg
>> and Not.
> Any test case to go with this?
>
No. It is fixing a potential problem that I found by inspection but from 
normal testing the feature was working fine. There was not a simple test 
case I could construct for the potential problem.
>>
>> On 10/26/2012 09:18 AM, Reed Kotler wrote:
>>> Author: rkotler
>>> Date: Fri Oct 26 11:18:19 2012
>>> New Revision: 166780
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=166780&view=rev
>>> Log: (empty)
>>>
>>> Modified:
>>>       llvm/trunk/lib/Target/Mips/Mips16InstrInfo.td
>>>
>>> Modified: llvm/trunk/lib/Target/Mips/Mips16InstrInfo.td
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/Mips16InstrInfo.td?rev=166780&r1=166779&r2=166780&view=diff
>>>
>>> ==============================================================================
>>> --- llvm/trunk/lib/Target/Mips/Mips16InstrInfo.td (original)
>>> +++ llvm/trunk/lib/Target/Mips/Mips16InstrInfo.td Fri Oct 26 11:18:19 2012
>>> @@ -205,6 +205,11 @@
>>>      FRR16<f, (outs ), (ins CPU16Regs:$rx, CPU16Regs:$ry),
>>>            !strconcat(asmstr, "\t$$zero, $rx, $ry"), [], itin> ;
>>>
>>> +class FUnaryRR16_ins<bits<5> f, string asmstr, InstrItinClass itin> :
>>> +  FRR16<f, (outs CPU16Regs:$rx), (ins CPU16Regs:$ry),
>>> +        !strconcat(asmstr, "\t$rx, $ry"), [], itin> ;
>>> +
>>> +
>>>    class FRR16_M_ins<bits<5> f, string asmstr,
>>>                      InstrItinClass itin> :
>>>      FRR16<f, (outs CPU16Regs:$rx), (ins),
>>> @@ -600,14 +605,14 @@
>>>    // Purpose: Negate
>>>    // To negate an integer value.
>>>    //
>>> -def NegRxRy16: FRR16_ins<0b11101, "neg", IIAlu>;
>>> +def NegRxRy16: FUnaryRR16_ins<0b11101, "neg", IIAlu>;
>>>
>>>    //
>>>    // Format: NOT rx, ry MIPS16e
>>>    // Purpose: Not
>>>    // To complement an integer value
>>>    //
>>> -def NotRxRy16: FRR16_ins<0b01111, "not", IIAlu>;
>>> +def NotRxRy16: FUnaryRR16_ins<0b01111, "not", IIAlu>;
>>>
>>>    //
>>>    // Format: OR rx, ry MIPS16e
>>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits